Add tpl support for ingress.labels, ingress.extraPaths and nodeSelector#400
Add tpl support for ingress.labels, ingress.extraPaths and nodeSelector#400treydock wants to merge 8 commits intooauth2-proxy:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the helm/oauth2-proxy chart’s Ingress templating capabilities by allowing Helm tpl evaluation within ingress.labels and ingress.extraPaths, and updates CI values and chart metadata accordingly.
Changes:
- Add
tplrendering foringress.labelsandingress.extraPathsin the Ingress template. - Extend the CI
tpl-values.yamlto cover templatedingress.labelsandingress.extraPaths. - Bump chart version and update the ArtifactHub changelog entry/link.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
helm/oauth2-proxy/templates/ingress.yaml |
Wraps ingress.labels and ingress.extraPaths YAML rendering with tpl to support templated values. |
helm/oauth2-proxy/ci/tpl-values.yaml |
Adds CI coverage values for the new templated Ingress fields. |
helm/oauth2-proxy/Chart.yaml |
Version bump and ArtifactHub changelog update referencing this PR. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@treydock, can you check the Copilot conversation? |
|
@pierluigilenoci I think some of the Copilot suggestions were incorrect but one suggestion was made to use |
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
treydock
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
|
@pierluigilenoci Let me know if any additional changes are required |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Could we stop opening a single PRs for each next element we want to add |
|
There was one large PR, but I missed a few things as I had intended to only open 1 PR. I can expand this PR to use |
|
@tuunit Let me know if you'd like me to update this PR to template most/all values with |
|
@pierluigilenoci @tuunit Let me know if you'd like me to expand more values to use |
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Description
Add deploymentLabels
Allow templated ingress labels, ingress extraPaths and nodeSelector
Checklist: